Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove sqlx #192

Merged
merged 9 commits into from
Jan 17, 2024
Merged

feat: remove sqlx #192

merged 9 commits into from
Jan 17, 2024

Conversation

TroyKomodo
Copy link
Member

@TroyKomodo TroyKomodo commented Jan 16, 2024 •
edited
Loading

Proposed changes

Remove SQLx in favor of tokio-postgres.
SQLx has had many issues. From the poor design of the query engine to
issues with transcations and deserializing. The idea of compile time
queries is pretty good but the SQLx implementation is just very sub par.
Most features are not supported.

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

-/-

@TroyKomodo TroyKomodo requested review from a team as code owners January 16, 2024 03:48
@TroyKomodo TroyKomodo changed the title Troy/database feat: remove sqlx Jan 16, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024 •
edited
Loading

Codecov Report

Attention: 1086 lines in your changes are missing coverage. Please review.

Comparison is base (52ac456) 46.72% compared to head (b1d83d6) 46.50%.
Report is 6 commits behind head on feature/website.

❗ Current head b1d83d6 differs from pull request most recent head 17ee76f. Consider uploading reports for the commit 17ee76f to get more accurate results

Additional details and impacted files 
@@                 Coverage Diff                 @@
##           feature/website     #192      +/-   ##
===================================================
- Coverage            46.72%   46.50%   -0.22%     
===================================================
  Files                  486      486              
  Lines                30818    31392     +574     
===================================================
+ Hits                 14399    14599     +200     
- Misses               16419    16793     +374
Files Coverage Δ
common/src/dataloader/mod.rs 95.20% <100.00%> (ø)
common/src/global.rs 100.00% <ø> (ø)
common/src/task.rs 79.16% <100.00%> (+0.12%) ⬆️
platform/image_processor/src/database.rs 100.00% <100.00%> (ø)
platform/image_processor/src/processor/mod.rs 0.00% <ø> (ø)
video/api/src/api/access_token/create.rs 90.00% <100.00%> (-0.33%) ⬇️
video/api/src/api/access_token/delete.rs 90.00% <100.00%> (-1.09%) ⬇️
video/api/src/api/events/ack.rs 58.69% <100.00%> (ø)
video/api/src/api/events/fetch.rs 76.08% <100.00%> (ø)
video/api/src/api/playback_key_pair/create.rs 91.66% <100.00%> (ø)
... and 129 more

... and 1 file with indirect coverage changes

lennartkloock
lennartkloock approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@lennartkloock lennartkloock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried everything and pushed my fixes

TroyKomodo and others added 9 commits January 17, 2024 21:29
@TroyKomodo
feat: remove sqlx
68336db 
Remove SQLx in favor of tokio-postgres.
SQLx has had many issues. From the poor design of the query engine to
issues with transcations and deserializing. The idea of compile time
queries is pretty good but the SQLx implementation is just very sub par.
Most features are not supported.
@TroyKomodo
chore: format
18ee912
@TroyKomodo
fix: deps
20dbd52
@TroyKomodo
fix: ingest tests
e979ba3
@TroyKomodo
fix: remove unused path
a984c69
@TroyKomodo
feat: add tls support
961b2fc
@lennartkloock @TroyKomodo
fix(platform): down migration
c3986ee
@lennartkloock @TroyKomodo
fix(platform): sql queries
bb14181
@TroyKomodo
fix: change filetype -> file_type
17ee76f
@TroyKomodo TroyKomodo merged commit a512725 into feature/website Jan 17, 2024
6 of 7 checks passed
@TroyKomodo TroyKomodo deleted the troy/database branch January 17, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SputNikPlop SputNikPlop SputNikPlop approved these changes

@lennartkloock lennartkloock Awaiting requested review from lennartkloock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TroyKomodo @lennartkloock @SputNikPlop